ci: do not fail a release when the DingTalk notification fails - #32
Merged
Conversation
The release workflow treated the DingTalk notification as a build gate: when the robot API rejects a message -- for example once its per-minute rate limit is exhausted -- the notification step failed and marked an otherwise successful publish as failed. Set `ignoreError` on every DingTalk step so a rejected notification is reported as a warning instead of failing the job. The publish outcome no longer depends on the notification channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow treats the DingTalk notification as a build gate. When the
robot API rejects a message — for example once its per-minute rate limit is
exhausted — the notification step fails, and a publish that actually succeeded
is reported as a failed run.
This is not hypothetical: a recent release published successfully to the
registry and still showed up red, purely because the notification was rejected.
Change
Set
ignoreError: "true"on everyzcong1993/actions-dingstep, so a rejectednotification is surfaced as a warning instead of failing the job.
The action supports this natively (
ignoreErroris a declared input). Messagecontent, destinations, and triggering conditions are unchanged.
Verification
actionlintoutput is byte-identical before and after on every touched file:the added lines introduce zero findings.