Pin the cronet-api test dependency instead of floating on latest - #26
Merged
Conversation
The module's tests compiled against "org.chromium.net:cronet-api:+", so every build resolved whatever version Chromium had published most recently. The latest release changed the Proxy and ProxyOptions constructors to private, which broke compilation of this module's tests and with it the release pipeline, without any change in this repository. The dependency is now pinned to 143.7445.0, the newest version whose Proxy API matches what the tests exercise. A test-compile classpath that shifts on its own has no place in a release build: version bumps should be deliberate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The cronet integration module declared its test-only cronet-api dependency as
org.chromium.net:cronet-api:+, so every build compiled the tests against whatever version Chromium had published most recently. Chromium's latest release (500.0.1) changed theProxyandProxyOptionsconstructors to private, which broke this module's test compilation — and with it the release pipeline forv0.6.0— without any change in this repository.The dependency is now pinned to
143.7445.0, the newest version whoseProxyAPI matches what the tests exercise (the compile-timecronet-apistays at141.7340.3, unchanged). A test classpath that shifts on its own has no place in a release build; moving to a newer cronet should be a deliberate bump.Verification
:integrations:dd-sdk-android-cronet:compileReleaseUnitTestKotlin— compiles.:integrations:dd-sdk-android-cronet:testReleaseUnitTestunder JDK 17 (the CI toolchain) — all 114 tests pass.Scope
One dependency line plus its comment. No production code, no API surface change.