Skip to content

Point Initialization Modernization and resulting code changes - #799

Open
masonwillman wants to merge 3 commits into
masterfrom
GUI-Redesign-point-fetch
Open

Point Initialization Modernization and resulting code changes#799
masonwillman wants to merge 3 commits into
masterfrom
GUI-Redesign-point-fetch

Conversation

@masonwillman

Copy link
Copy Markdown
Contributor

This PR updates the methods used for fetchStationData from GDAL's OGR functions to CPLJSON functions.

  • fetchStationData has been reimplemented with clearer variable names, comments, and methods
  • Removed unneeded functions after CPLJSON implementation.

@latwood take a look at the changes and see if there is anything else that needs fixed. Additional items needed added to the PR before merging

  • Update vcpkg so Windows and Linux use the same dependency versions (this re-implementation was caused by a bug with newer GDAL versions)
  • Add a API key secret related to point initialization fetching.

@latwood

latwood commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

@masonwillman tested again, works on my Windows and Ubuntu builds.

For the record, this also fixes the issue I was experiencing on Windows, where OGR_F_GetFieldAsDoubleList() calls were failing because the data were seen as string instead of as type realList. OGR_F_GetFieldAsString() worked but required a bunch of extra parsing because OGR_F_GetFieldAsStringList() wouldn't work. The CPLJSON functions turned out to be a more direct fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants