Make firestore-incremental-capture public - #2969
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package.json of the firestore-incremental-capture kit to set private to false, preparing it for public release. The reviewer suggested adding publishConfig.access set to "public" to ensure the scoped package can be published successfully without issues.
| "directory": "kits/firestore-incremental-capture" | ||
| }, | ||
| "private": true, | ||
| "private": false, |
Contributor
There was a problem hiding this comment.
Since this is a scoped package (@firebase-function-kits/firestore-incremental-capture), publishing it publicly requires the publishConfig.access field to be set to "public". Otherwise, npm publish may fail or attempt to publish it as restricted.
Suggested change
| "private": false, | |
| "private": false, | |
| "publishConfig": { | |
| "access": "public" | |
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.