[SEC-452] fix(client): compatibilidad con http.rb 6 - #30
Merged
Conversation
http.rb 6 made the verb methods keyword-only, so passing the options hash positionally raises ArgumentError on every request the SDK makes. Splatting it keeps working on http.rb 5, so consumers can stay on either major. The dev lock moves to http 6.0.4 and webmock 3.26.2 (the release that added http.rb 6 support to its adapter) so CI runs against the version that used to break.
VicenteSotoArmijo
marked this pull request as ready for review
August 19, 2026 20:40
npcastro
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
http.rb 6 dejó los métodos de verbo como keyword-only, y
make_requestle pasa las opciones como hash posicional, así que toda llamada del SDK revienta conArgumentError. Es lo que bloquea el bump dehttpen fintoc-rails.¿Qué hay de nuevo?
make_requestsplatea las opciones:send(method, url, **parameters)El splat funciona igual en http.rb 5, así que el gemspec queda sin pin.
Tests
Safety Checks
Consideraciones
Toca
Gemfile.lockigual que #28, conviene mergear ese primero y rebasear. #29 queda sin sentido: http 6 no usa llhttp-ffi, así queffi-compilerdesaparece del lock.Rollback
¿Es seguro hacer rollback?
Sí.