Skip to content

Fix file upload/download - #34

Merged
jacob-curley-fnal merged 1 commit into
mainfrom
allow_file_downloads
May 14, 2026
Merged

Fix file upload/download#34
jacob-curley-fnal merged 1 commit into
mainfrom
allow_file_downloads

Conversation

@jacob-curley-fnal

@jacob-curley-fnal jacob-curley-fnal commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Updated the flags for starting Xpra so that the file download path is fixed. Also switched the working directory to be the user's home dir. This way the file explorer dialogs within Xpra will default to the same location that the app dumps its files. Prevents users from needing to dig around in the Xpra file system to find their files.

Resolves #27

@github-actions

Copy link
Copy Markdown

Code Coverage Report - 46 of 117 lines covered ( ⛔ 39.32%)

src - 46 of 117 lines covered ( ⛔ 39.32%)

src/ap_python_starter_kit - 46 of 117 lines covered ( ⛔ 39.32%)

src/ap_python_starter_kit/init.py - 0 of 2 lines covered ( ⛔ 0.00%)

⛔ This file is missing coverage.

src/ap_python_starter_kit/acsys_client.py - 9 of 28 lines covered ( ⛔ 32.14%)

Uncovered lines: ⚠️ 18-19, 21-24, 26-28, 30, 34, 36-38, 40-41, 45-46, 48

src/ap_python_starter_kit/gui.py - 16 of 65 lines covered ( ⛔ 24.62%)

Uncovered lines: ⚠️ 12-13, 20-23, 25-26, 28-31, 33-34, 36, 39, 42, 45, 51, 58-59, 61-65, 67-68, 70-73, 75, 77-82, 84-85, 87-88, 90-91, 95-98

src/ap_python_starter_kit/main.py - 21 of 22 lines covered ( ✅ 95.45%)

Uncovered lines: ⚠️ 47

@jacob-curley-fnal
jacob-curley-fnal merged commit 87fdd73 into main May 14, 2026
4 checks passed
@jacob-curley-fnal
jacob-curley-fnal deleted the allow_file_downloads branch May 14, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xpra's download file feature doesn't work

2 participants