Skip to content

Add fixes for DevPod issues on Windows - #32

Merged
chowington merged 2 commits into
mainfrom
windows-devpod-fixes
May 11, 2026
Merged

Add fixes for DevPod issues on Windows#32
chowington merged 2 commits into
mainfrom
windows-devpod-fixes

Conversation

@chowington

@chowington chowington commented May 11, 2026

Copy link
Copy Markdown
Collaborator

The fix for the second issue I'm fairly confident about. The fix for the first issue I'm only somewhat confident about 😅

I don't know how common these issues are -- if they're common (or inevitable given our current setup), they can go straight into the main setup directions

Feel free to add to this branch with other helpful directions for this wonderful setup we've got going on here

@github-actions

Copy link
Copy Markdown

Code Coverage Report - 46 of 117 lines covered ( ⛔ 39.32%)

src - 46 of 117 lines covered ( ⛔ 39.32%)

src/ap_python_starter_kit - 46 of 117 lines covered ( ⛔ 39.32%)

src/ap_python_starter_kit/init.py - 0 of 2 lines covered ( ⛔ 0.00%)

⛔ This file is missing coverage.

src/ap_python_starter_kit/acsys_client.py - 9 of 28 lines covered ( ⛔ 32.14%)

Uncovered lines: ⚠️ 18-19, 21-24, 26-28, 30, 34, 36-38, 40-41, 45-46, 48

src/ap_python_starter_kit/gui.py - 16 of 65 lines covered ( ⛔ 24.62%)

Uncovered lines: ⚠️ 12-13, 20-23, 25-26, 28-31, 33-34, 36, 39, 42, 45, 51, 58-59, 61-65, 67-68, 70-73, 75, 77-82, 84-85, 87-88, 90-91, 95-98

src/ap_python_starter_kit/main.py - 21 of 22 lines covered ( ✅ 95.45%)

Uncovered lines: ⚠️ 47

@chowington
chowington marked this pull request as ready for review May 11, 2026 15:17

@jacob-curley-fnal jacob-curley-fnal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one other thing you could add is a mention about deleting the .docker directory from C:\Users\<your user>, as that was my fix. I agree that this could be pretty niche for us as full-time developers, but might be worth preserving all the same

@github-actions

Copy link
Copy Markdown

Code Coverage Report - 46 of 117 lines covered ( ⛔ 39.32%)

src - 46 of 117 lines covered ( ⛔ 39.32%)

src/ap_python_starter_kit - 46 of 117 lines covered ( ⛔ 39.32%)

src/ap_python_starter_kit/init.py - 0 of 2 lines covered ( ⛔ 0.00%)

⛔ This file is missing coverage.

src/ap_python_starter_kit/acsys_client.py - 9 of 28 lines covered ( ⛔ 32.14%)

Uncovered lines: ⚠️ 18-19, 21-24, 26-28, 30, 34, 36-38, 40-41, 45-46, 48

src/ap_python_starter_kit/gui.py - 16 of 65 lines covered ( ⛔ 24.62%)

Uncovered lines: ⚠️ 12-13, 20-23, 25-26, 28-31, 33-34, 36, 39, 42, 45, 51, 58-59, 61-65, 67-68, 70-73, 75, 77-82, 84-85, 87-88, 90-91, 95-98

src/ap_python_starter_kit/main.py - 21 of 22 lines covered ( ✅ 95.45%)

Uncovered lines: ⚠️ 47

@chowington
chowington merged commit 926139f into main May 11, 2026
4 checks passed
@chowington
chowington deleted the windows-devpod-fixes branch May 11, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants