fix(desktop): round share invite email field and button - #6980
Draft
ComputelessComputer wants to merge 1 commit into
Draft
fix(desktop): round share invite email field and button#6980ComputelessComputer wants to merge 1 commit into
ComputelessComputer wants to merge 1 commit into
Conversation
The email input and Invite action used rounded-md, which looked sharp against the rest of the share popover. Use the same pill radius as other share actions. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
✅ Deploy Preview for anarlog canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The share popover’s email field and Invite button used
rounded-md, so they looked sharper than the rest of that menu.Both now use
rounded-full, matching the app’s pill buttons.Test plan
pnpm exec dprint fmton changed filespnpm exec oxlint --quiet --format=githubon changed filespnpm -F desktop typecheckpnpm -F desktop exec vitest run src/session-sharing/invite-recipients.test.tsx