fix(desktop): match folder picker popover to metadata chrome - #6979
Merged
Conversation
The folder menu used p-0 and a tight cmdk search row, so it lost the inset panel, padding, and divider of the calendar metadata popover. Reuse that chrome width, inner padding, and divider. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
✅ Deploy Preview for anarlog canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The folder picker popover used
p-0and a tight cmdk search row, so it didn’t match the calendar metadata popover’s inset chrome, padding, or divider.This reuses that shell: same width, inner
p-4layout, search row height, andbg-accentdivider.Test plan
pnpm exec dprint fmton changed filespnpm exec oxlint --quiet --format=githubon changed filespnpm -F desktop typecheckpnpm -F desktop exec vitest run src/session/components/folder-picker.test.tsx