feature: add support for custom schemas in the MSSQL integration#1148
Open
CarlosZaldivar wants to merge 2 commits into
Open
feature: add support for custom schemas in the MSSQL integration#1148CarlosZaldivar wants to merge 2 commits into
CarlosZaldivar wants to merge 2 commits into
Conversation
This is technically a breaking change for people that specified a different default schema than "dbo" for their DB user, because now EventFlow will always use "dbo" without an explicit override, regardless of the DB user configuration. I don't think that changing the default schema for a user is a common scenario though, because the snapshot code had a hardcoded "dbo" in its scripts, which tells me that almost no one has been doing it. Otherwise they would have run into schema inconsistency regarding the snapshot store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change for people that specified a different default schema than "dbo" for their DB user, because now EventFlow will always use "dbo" without an explicit override, regardless of the DB user configuration.
I don't think that changing the default schema for a user is a common scenario though, because the snapshot code had a hardcoded "dbo" in its scripts, which tells me that almost no one has been doing it. Otherwise they would have run into schema inconsistency regarding the snapshot store.