fix(aws): paginate resource inventory using boto3 paginators#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_aws_resource_inventoryincore/utils_aws.pyused a hand-rolledwhile "NextToken" in responseloop, which only paginated services that useNextToken. Services paginating byMarker,NextMarker,ContinuationToken,ExclusiveStartTableName, or lowercasenextTokenwere silently truncated to their first page — e.g. DynamoDBlist_tablescapped at 100, S3 buckets past the first page missing.paginate()/paginate_or_call()helper incore/utils_aws.py, and refactoredcore/utils_egress_aws.pyto use the same helper (removing its duplicate_paginate). Both inventory and egress now paginate identically, so DynamoDB (and every other multi-page resource type) counts match across the two paths.Throttling/RequestLimitExceeded/BotoCoreErrornow applies per page, not just per initial call.