Skip to content

Revert "gh: drop Codecov token, upload works without one for fork PRs" #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xdelaruelle wants to merge 1 commit into from
+14 −21
Closed

Revert "gh: drop Codecov token, upload works without one for fork PRs" #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions .github/workflows/linux_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ jobs:
- name: Uninstall Modules
run: |
make uninstall
# no token needed: public repo uses Codecov's tokenless upload via
# GitHub OIDC, which also works for pull requests coming from forks
# (base repo secrets are never exposed to fork-triggered PR runs)
- uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v7
if: failure()
with:
Expand Down Expand Up @@ -155,10 +154,9 @@ jobs:
- name: Uninstall Modules
run: |
make uninstall
# no token needed: public repo uses Codecov's tokenless upload via
# GitHub OIDC, which also works for pull requests coming from forks
# (base repo secrets are never exposed to fork-triggered PR runs)
- uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v7
if: failure()
with:
Expand Down Expand Up @@ -239,10 +237,9 @@ jobs:
- name: Uninstall Modules
run: |
make uninstall
# no token needed: public repo uses Codecov's tokenless upload via
# GitHub OIDC, which also works for pull requests coming from forks
# (base repo secrets are never exposed to fork-triggered PR runs)
- uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v7
if: failure()
with:
Expand Down Expand Up @@ -308,10 +305,9 @@ jobs:
- name: Uninstall Modules
run: |
make uninstall
# no token needed: public repo uses Codecov's tokenless upload via
# GitHub OIDC, which also works for pull requests coming from forks
# (base repo secrets are never exposed to fork-triggered PR runs)
- uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v7
if: failure()
with:
Expand Down Expand Up @@ -379,10 +375,9 @@ jobs:
- name: Uninstall Modules
run: |
make uninstall
# no token needed: public repo uses Codecov's tokenless upload via
# GitHub OIDC, which also works for pull requests coming from forks
# (base repo secrets are never exposed to fork-triggered PR runs)
- uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v7
if: failure()
with:
Expand Down Expand Up @@ -525,10 +520,9 @@ jobs:
- name: Uninstall Modules
run: |
make uninstall
# no token needed: public repo uses Codecov's tokenless upload via
# GitHub OIDC, which also works for pull requests coming from forks
# (base repo secrets are never exposed to fork-triggered PR runs)
- uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v7
if: failure()
with:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/macos_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,9 @@ jobs:
- name: Uninstall Modules
run: |
make uninstall
# no token needed: public repo uses Codecov's tokenless upload via
# GitHub OIDC, which also works for pull requests coming from forks
# (base repo secrets are never exposed to fork-triggered PR runs)
- uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v7
if: failure()
with:
Expand Down
Loading