NXT-16498: [Spotlight] Create sample for spotlight module#274
Open
dan-ichim-lgp wants to merge 4 commits into
Open
NXT-16498: [Spotlight] Create sample for spotlight module#274dan-ichim-lgp wants to merge 4 commits into
dan-ichim-lgp wants to merge 4 commits into
Conversation
ion-andrusciac-lgp
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Adds interactive embedded samples to the Enact documentation site, starting with the spotlight-sandbox sample from enactjs/samples. Spotlight API pages display a relevant sandbox demo via iframe alongside existing Live Preview snippets.
Resolution
prepare-raw.mjs — clones enactjs/samples (develop) into raw/samples
make-runner.mjs — imports prepare-raw, builds samples listed in src/config/sampleEmbeds.json into public/
src/config/sampleEmbeds.json — central config for sample build paths, embed URLs, and per-module route mapping
SampleEmbed / SampleEmbedSection — iframe component and section rendered on matching API pages
[...data].astro — adds SampleEmbedSection to auto-generated module pages
.gitignore — ignores public/ (sample runner and embedded sample build output)
README.md — documents samples clone and config
Spotlight module pages map to sandbox routes (e.g. spotlight/Spottable → #/SandboxSample, spotlight/SpotlightContainerDecorator → #/ContainerSample).
New samples can be added by extending sampleEmbeds.json without changing layout or build scripts.
Additional Considerations
Links
NXT-16498
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)