Skip to content

Don't check if DBConnection is loaded.#734

Merged
josevalim merged 1 commit into
elixir-ecto:masterfrom
christhekeele:dont-check-if-db-connection-is-loaded
Jun 14, 2026
Merged

Don't check if DBConnection is loaded.#734
josevalim merged 1 commit into
elixir-ecto:masterfrom
christhekeele:dont-check-if-db-connection-is-loaded

Conversation

@christhekeele

@christhekeele christhekeele commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

AFAICT,

  • This check has been present since the original commit to ecto_sql
  • But DBConnection has been a required dependency since the original commit
  • So this check has always been unnecessary since the repo was public, and is probably a remnant of an original prototype where it was an optional dependency

@josevalim josevalim merged commit 6508668 into elixir-ecto:master Jun 14, 2026
8 of 10 checks passed
@josevalim

josevalim commented Jun 14, 2026

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christhekeele @josevalim