Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions classes/publish/package/tasks/upload-files.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ export default class UploadFiles extends Task {
`Package with name "${name}" and version "${version}" already exists on server`,
{ cause: err },
);
case 413:
throw new Error(
`${e.statusCode}: Package is too large to upload. Reduce the package size.`,
{ cause: err },
);
case 415:
throw new Error(
`${e.statusCode}: Client attempted to send an unsupported file format to server`,
Expand Down
54 changes: 54 additions & 0 deletions test/publish.package.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -325,3 +325,57 @@ describe("publish package", () => {
assert.ok(l.logs.debug.includes("Cleaning up"));
});
});

describe("publish package - upload size limit", () => {
let server;
let address;
let token;
let cwd;

beforeEach(async () => {
const memSink = new Sink();
server = fastify({ logger: false, forceCloseConnections: true });
const service = new EikService({ customSink: memSink, pkgMaxFileSize: 1 });
server.register(service.api());
address = await server.listen({
host: "127.0.0.1",
port: 0,
});

token = await cli.login({
server: address,
key: "change_me",
});

cwd = await fs.mkdtemp(join(os.tmpdir(), basename(__filename)));
});

afterEach(async () => {
await server.close();
});

test("Uploading a package that exceeds the server size limit gives a clear error", async () => {
const l = mockLogger();

await assert.rejects(
cli.publish({
logger: l.logger,
cwd,
server: address,
name: "my-app",
token,
version: "1.0.0",
files: {
"index.js": join(__dirname, "./fixtures/client.js"),
},
}),
(/** @type {Error} */ err) => {
assert.ok(
err.message.includes("too large"),
`Expected error message to mention the package is too large, got: ${err.message}`,
);
return true;
},
);
});
});