fix: strips URI scheme prefixes from DD_DOGSTATSD_URL - #556
Open
hshree-cs wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gunicorn configuration used in containerized deployments to normalize DD_DOGSTATSD_URL into a value suitable for Gunicorn’s StatsD/DogStatsD configuration, aiming to prevent metrics initialization errors when the environment variable includes a URI scheme.
Changes:
- Adds scheme-stripping/normalization logic for
DD_DOGSTATSD_URLbefore assigningstatsd_host. - Adds startup logging to record the configured
statsd_host.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| import os | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) |
Comment on lines
+22
to
33
| # Strip protocol schemes so Gunicorn receives the raw file path or HOST:PORT | ||
| if _dogstatsd_url.startswith("unix://"): | ||
| # Gunicorn accepts unix socket directly as "unix:///path". | ||
| _statsd_host = _dogstatsd_url if _dogstatsd_url != "unix://" else "" | ||
| _statsd_host = _dogstatsd_url[len("unix://"):] | ||
| elif _dogstatsd_url.startswith("unixpack://"): | ||
| _statsd_host = _dogstatsd_url[len("unixpack://"):] | ||
| elif _dogstatsd_url.startswith("udp://"): | ||
| _statsd_host = _dogstatsd_url[len("udp://"):] | ||
| else: | ||
| # Strip "udp://" when present; Gunicorn expects plain "HOST:PORT". | ||
| _statsd_host = ( | ||
| _dogstatsd_url[len("udp://"):] | ||
| if _dogstatsd_url.startswith("udp://") | ||
| else _dogstatsd_url | ||
| ).strip() | ||
| _statsd_host = _dogstatsd_url | ||
|
|
||
| if _statsd_host: | ||
| statsd_host = _statsd_host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes metrics error by stripping protocol prefixes (unix://) from DD_DOGSTATSD_URL.
Merge checklist:
Check off if complete or not applicable:
Post-merge: