fix(recipe): set the component token for GG_CONFIG runs - #17
Merged
Conversation
The Greengrass recipe's DefaultConfiguration was the one configuration surface without `component.token`. With no token set, the library falls back to the short form of the Greengrass component name, which is reverse-DNS PascalCase — so a GG_CONFIG run published under the PascalCase name while the k8s ConfigMap and every FILE config in this repo already carried the lower-kebab token, and every doc in the repo documents the kebab topics. Set the token explicitly in the recipe, matching the value the other surfaces already use. Purely additive: no other surface changes, and the kebab token was already what non-Greengrass deployments published under.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
recipe.yaml'sComponentConfiguration.DefaultConfiguration.componentblock was the oneconfiguration surface in this repo without
component.token.Core resolves the UNS
{component}token ascomponent.tokenfrom the active config document,falling back to the last segment of the reverse-DNS Greengrass component name when it is absent —
and that fallback is PascalCase. So a
--platform GREENGRASS -c GG_CONFIGrun published under thePascalCase name, while this repo's k8s ConfigMap and every FILE config already carried the
lower-kebab token, and every doc here documents the kebab topics.
Change
One addition to
recipe.yaml: the token, set to the same lower-kebab value the repo's otherconfiguration surfaces already use, with a comment explaining why it is set explicitly rather than
derived.
Not a breaking wire change. The token value is unchanged from what this repo already publishes
under on the FILE and CONFIGMAP paths — this only makes the Greengrass path agree with them.
Standard
schema/edgecommons-config-schema.jsonpinscomponent.tokento^[a-z0-9]+(?:-[a-z0-9]+)*$.PascalCase belongs only to the Greengrass component name, which never reaches the wire.
Same fix as mtconnect-adapter#5.