Add search in development help - #2582
Open
TruongQuangSB wants to merge 2 commits into
Open
Conversation
Test Results147 tests ±0 147 ✅ ±0 8m 31s ⏱️ +5s Results for commit b27b4ea. ± Comparison against base commit 2ceb0d9. This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mariusheine
requested changes
Aug 2, 2026
| document.addEventListener("keydown", (ev) => { | ||
| if (ev.ctrlKey && ev.key === "f") { | ||
| document.body.appendChild(createSearchFeld()) | ||
| if (document.getElementById("searchFeld") !== null) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (document.getElementById("searchFeld") !== null) { | |
| if (document.getElementById("searchInput") !== null) { |
| if (ev.ctrlKey && ev.key === "f") { | ||
| document.body.appendChild(createSearchFeld()) | ||
| if (document.getElementById("searchFeld") !== null) { | ||
| close() |
Contributor
There was a problem hiding this comment.
@TruongQuangSB Shall we really close the search field? The common handling e.g. in the browser is to just focus the search field again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.