Skip to content

feat(tooling): migrate C++ formatting to central format_checker, appl…#114

Open
lavrovvalera wants to merge 1 commit into
eclipse-score:mainfrom
lavrovvalera:vala_format_code
Open

feat(tooling): migrate C++ formatting to central format_checker, appl…#114
lavrovvalera wants to merge 1 commit into
eclipse-score:mainfrom
lavrovvalera:vala_format_code

Conversation

@lavrovvalera

Copy link
Copy Markdown
Contributor

…y clang-format

  • Remove score_bazel_tools_cc (old per-project clang-format aspect) and its Python 3.8 workaround; drop the --config=clang_format bazelrc block
  • Add format_multirun/format_test targets from @aspect_rules_lint with cc = "@llvm_toolchain//:clang-format" — equivalent to the upcoming use_format_targets(languages=[..., "cpp"]) from score_tooling
  • Pin score_tooling to commit 2ea6153 (via git_override) which introduces the languages parameter; cascade lobster and updated trlc overrides required by that commit
  • Bump score_baselibs 0.2.7 → 0.2.9 (fixes StringLiteral self-deprecation that caused clang-tidy to fail on message_parser_test)
  • Fix pre-existing -Wbraced-scalar-init in vehicle_clock_test.cpp (double-brace {{x}} → single-brace {x} for ClockStatus initializer)
  • Apply clang-format --style=file to all C++ sources (~100 files)

Closes #113, #103

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: bf153196-2f5e-4deb-8041-b4a5456a733d
Computing main repo mapping: 
WARNING: /home/runner/work/time/time/MODULE.bazel:13:7: The attribute 'compatibility_level' in module() is a no-op and will be removed in a future Bazel release. Please remove it from your MODULE.bazel file.
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (51 packages loaded, 10 targets configured)

Analyzing: target //:license-check (83 packages loaded, 10 targets configured)

Analyzing: target //:license-check (140 packages loaded, 554 targets configured)

Analyzing: target //:license-check (152 packages loaded, 4813 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6170 targets configured)

Analyzing: target //:license-check (159 packages loaded, 6180 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6219 targets configured)

Analyzing: target //:license-check (165 packages loaded, 8106 targets configured)

Analyzing: target //:license-check (165 packages loaded, 8106 targets configured)

Analyzing: target //:license-check (168 packages loaded, 11288 targets configured)

Analyzing: target //:license-check (169 packages loaded, 11296 targets configured)

Analyzing: target //:license-check (169 packages loaded, 11296 targets configured)

Analyzing: target //:license-check (169 packages loaded, 11296 targets configured)

Analyzing: target //:license-check (169 packages loaded, 11296 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 11422 targets configured).
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 34.183s, Critical Path: 2.56s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

- Remove `score_bazel_tools_cc` (old per-project clang-format aspect) and its
  Python 3.8 workaround; drop the `--config=clang_format` bazelrc block
- Enable C++ in `use_format_targets(languages=[..., "cpp"])` from score_tooling;
  pin score_tooling to commit 2ea6153 (via `git_override`) which introduces the
  `languages` parameter; cascade `lobster` and updated `trlc` overrides required
  by that commit
- Bump `score_baselibs` 0.2.7 → 0.2.9 (fixes `StringLiteral` self-deprecation
  that caused clang-tidy to fail on `message_parser_test`)
- Fix pre-existing `vehicle_clock_test.cpp`
- Apply `clang-format --style=file` to all C++ sources (~100 files)
- CI: replace two-job format workflow with a single one
- Docs: update formatting section

Closes eclipse-score#113, eclipse-score#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Enable C++ formatting via score_format_checker (replace score_bazel_tools_cc)

1 participant