Skip to content

docs: add detailed design for datarouter and mw/log components#177

Open
RSingh1511 wants to merge 1 commit into
eclipse-score:mainfrom
RSingh1511:rs/detailed-design-docs
Open

docs: add detailed design for datarouter and mw/log components#177
RSingh1511 wants to merge 1 commit into
eclipse-score:mainfrom
RSingh1511:rs/detailed-design-docs

Conversation

@RSingh1511

Copy link
Copy Markdown
Contributor

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 0d6496ee-ac85-4052-a4e3-90ba7664cdf4
Computing main repo mapping: 
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.9, but got score_crates@0.0.10 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 5.239s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@RSingh1511 RSingh1511 force-pushed the rs/detailed-design-docs branch from dcad393 to 3334894 Compare July 1, 2026 13:31
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 1, 2026 13:31 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 1, 2026 13:31 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 1, 2026 13:31 — with GitHub Actions Waiting

@rmaddikery rmaddikery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detailed design needs to direct the users to existing detailed design documentation and not generate more text that is obvious from the sources.

@RSingh1511 RSingh1511 force-pushed the rs/detailed-design-docs branch from 3334894 to e5560ab Compare July 3, 2026 06:55
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 3, 2026 06:55 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 3, 2026 06:55 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 3, 2026 06:55 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 force-pushed the rs/detailed-design-docs branch from e5560ab to 79a8bb8 Compare July 3, 2026 07:24
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 3, 2026 07:24 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 3, 2026 07:24 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 3, 2026 07:24 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a deployment to workflow-approval July 3, 2026 07:24 — with GitHub Actions Waiting
@RSingh1511 RSingh1511 requested a review from rmaddikery July 3, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants