mw/com: Add the integration tests for moving proxyEvent#607
Open
sahithi-nukala wants to merge 3 commits into
Open
mw/com: Add the integration tests for moving proxyEvent#607sahithi-nukala wants to merge 3 commits into
sahithi-nukala wants to merge 3 commits into
Conversation
sahithi-nukala
force-pushed
the
sah_proxy_event_move_tests
branch
from
544058d to
49a2440
Compare
bemerybmw
reviewed
Jun 29, 2026
| return *proxy_; | ||
| } | ||
|
|
||
| Proxy&& Extract() |
Contributor
There was a problem hiding this comment.
directory structure:
move_semantics/
....proxy_event/
....skeleton_event/
bemerybmw
reviewed
Jun 29, 2026
| ProxyStateChangeNotifier(const ProxyStateChangeNotifier&&) = delete; | ||
| ProxyStateChangeNotifier& operator=(const ProxyStateChangeNotifier&&) = delete; | ||
|
|
||
| bool WaitForStateChange(const score::cpp::stop_token& stop_token, SubscriptionState desired_state) |
Contributor
There was a problem hiding this comment.
Suggested change
| bool WaitForStateChange(const score::cpp::stop_token& stop_token, SubscriptionState desired_state) | |
| [[nodiscard]] bool WaitForStateChange(const score::cpp::stop_token& stop_token, SubscriptionState desired_state) |
If false is returned, we never got the expected state change so should terminate.
bemerybmw
reviewed
Jun 29, 2026
| ProxyEventReceiver(const ProxyEventReceiver&&) = delete; | ||
| ProxyEventReceiver& operator=(const ProxyEventReceiver&&) = delete; | ||
|
|
||
| void WaitForSamples(const score::cpp::stop_token& stop_token, const std::size_t num_samples_to_receive) |
Contributor
There was a problem hiding this comment.
Suggested change
| void WaitForSamples(const score::cpp::stop_token& stop_token, const std::size_t num_samples_to_receive) | |
| [[nodiscard]] bool WaitForSamples(const score::cpp::stop_token& stop_token, const std::size_t num_samples_to_receive) |
if false, didn't receive expected samples so should fail test.
sahithi-nukala
force-pushed
the
sah_proxy_event_move_tests
branch
6 times, most recently
from
94c8dd5 to
f486d86
Compare
sahithi-nukala
force-pushed
the
sah_proxy_event_move_tests
branch
from
f486d86 to
c755a1c
Compare
sahithi-nukala
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the integration tests that verify a Proxy (and its ProxyEvent) can be moved without disrupting service discovery, subscription, or sample reception.
Issue: #483