Rust::com Cleanup deprecated Rust APIs#602
Merged
LittleHuba merged 4 commits intoJul 6, 2026
Merged
Conversation
bharatGoswami8
force-pushed
the
Rust_old_APIs_cleanup
branch
from
92a6923 to
96bf67a
Compare
| @@ -56,10 +56,9 @@ | |||
| // - This enables type-safe communication without C++ needing to know Rust types at compile time | |||
| // | |||
| // Dependencies: | |||
| // - It relies on proxy_bridge_rs crate for FatPtr and ProxyWrapperClass definitions | |||
| // - C FFI implementations (mw_com_impl_*) are all in registry_bridge_macro.cpp | |||
There was a problem hiding this comment.
Suggestion:
Better to add bridge_ffi.rs in separate folder as its generic FFI interface abstraction and currently implemented by lola but eventually it can be implemented by any other communication mechanism
Contributor
Author
There was a problem hiding this comment.
Yes, we can plan to move with common file but may be with separate PR or when Method/Field FFI implementation we are doing that time it may help to create separate interface file.
As this PR for cleanup old APIs so i think we can keep it in same folder as of now.
bharatGoswami8
force-pushed
the
Rust_old_APIs_cleanup
branch
2 times, most recently
from
da146a1 to
2a1164e
Compare
bharatGoswami8
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
bharatGoswami8
force-pushed
the
Rust_old_APIs_cleanup
branch
2 times, most recently
from
38742d1 to
e5d8eb9
Compare
tejaswinijoshi89
approved these changes
Jul 1, 2026
Contributor
Author
|
PR required review from @darkwisebear, so please do not merge it. |
…d APIs * Removed the Rust Old APIs implementation and target * Updated the re-used code into FFI folder
* Move the init in FFI trait * Created common_rs for ffi
bharatGoswami8
force-pushed
the
Rust_old_APIs_cleanup
branch
from
e5d8eb9 to
951a6f5
Compare
LittleHuba
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#432