adapter.json: Remove duplicate @classmethod#595
Merged
s-heppner merged 1 commit intoJul 15, 2026
Conversation
Previously, `_construct_blob` in `json_deserialization.py` was decorated with `@classmethod` twice, producing a `classmethod(classmethod(func))` wrapper. On Python 3.10 and 3.12 (used in CI) this went unnoticed, because `classmethod` chained through the inner descriptor and still resolved to a callable bound method. Python 3.13 removed that descriptor chaining, so accessing `cls._construct_blob` now yields a raw, non-callable `classmethod` object. As a result, deserializing any `Blob` raised `TypeError: 'classmethod' object is not callable`, breaking JSON deserialization and the AASX round-trip tests on 3.13. This change removes the redundant decorator so `_construct_blob` behaves like all other constructor methods. This finding motivated eclipse-basyx#594.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
_construct_blobinjson_deserialization.pywas decorated with@classmethodtwice, producing aclassmethod(classmethod(func))wrapper.On Python 3.10 and 3.12 (used in CI) this went unnoticed, because
classmethodchained through the inner descriptor and still resolved to a callable bound method. Python 3.13 removed that descriptor chaining, so accessingcls._construct_blobnow yields a raw, non-callableclassmethodobject. As a result, deserializing anyBlobraisedTypeError: 'classmethod' object is not callable, breaking JSON deserialization and the AASX round-trip tests on 3.13.This change removes the redundant decorator so
_construct_blobbehaves like all other constructor methods.This finding motivated #594.