Skip to content

[25442] Make skip-ci label report required statuses as pass#307

Open
MiguelCompany wants to merge 4 commits into
masterfrom
hotfix/actions-if-on-steps
Open

[25442] Make skip-ci label report required statuses as pass#307
MiguelCompany wants to merge 4 commits into
masterfrom
hotfix/actions-if-on-steps

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Move conditionals in the CI from jobs to steps, so the options in matrix are always considered, and thus all the corresponding statuses are shown as passed when the skip-ci label is present.

@Mergifyio backport 2.2.x 1.4.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jun 18, 2026
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 18, 2026
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 18, 2026 14:19
@MiguelCompany MiguelCompany marked this pull request as ready for review June 18, 2026 14:25
@MiguelCompany MiguelCompany added this to the v2.6.2 milestone Jun 18, 2026
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Jun 19, 2026
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 19, 2026 07:36
@MiguelCompany
Refs #25442. Move execution conditions to steps.
f883821 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #25442. Update condition for run-tests.
a348b09 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #25442. Similar changes for windows.
1e3b24e 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #25442. Don't upload build artifact when tests are skipped.
55f562a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the hotfix/actions-if-on-steps branch from 6c9df08 to 55f562a Compare June 19, 2026 07:56
@MiguelCompany MiguelCompany changed the title Move execution conditions to steps [25442] Make skip-ci label report required statuses as pass Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiprosima richiprosima Awaiting requested review from richiprosima

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Milestone

v2.6.2

Development

Successfully merging this pull request may close these issues.

1 participant

@MiguelCompany