Skip to content

[#24620] Added regression tests for DDS-Pipe Dispose fix in DDS-Router repeater#542

Merged
Danipiza merged 3 commits into
mainfrom
fix/dispose
Jun 19, 2026
Merged

[#24620] Added regression tests for DDS-Pipe Dispose fix in DDS-Router repeater#542
Danipiza merged 3 commits into
mainfrom
fix/dispose

Conversation

@Danipiza

@Danipiza Danipiza commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Added regression tests for DDS-Pipe Dispose fix in DDS-Router repeater

Compilation & Testing

colcon build --packages-select ddspipe_participants ddsrouter_core --cmake-args -DBUILD_TESTS=ON --allow-overriding ddspipe_participants ddsrouter_core
colcon test --packages-select ddsrouter_core --ctest-args -R DDSTestRepeaterDisposeKey --event-handlers console_direct+

Artifacts

ddspipe_build: https://github.com/eProsima/eProsima-CI/actions/runs/27612271887 🟢
ddspipe_build: https://github.com/eProsima/eProsima-CI/actions/runs/27612284847 🟢

DDS-Router with the DDS-Pipe fix: Action 🟢
DDS-Router with the DDS-Pipe fix (with revision): Action 🟢

@zesk1999 zesk1999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just one nit present from before.

Comment thread ddsrouter_core/test/blackbox/ddsrouter_core/dds/repeater/CMakeLists.txt Outdated
Comment thread ddsrouter_core/test/blackbox/ddsrouter_core/dds/repeater/CMakeLists.txt Outdated

@zesk1999 zesk1999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

Danipiza added 2 commits June 18, 2026 07:13
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.24%. Comparing base (0e670ae) to head (610f570).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   31.14%   30.24%   -0.90%     
==========================================
  Files          16       16              
  Lines         594      562      -32     
  Branches      321      298      -23     
==========================================
- Hits          185      170      -15     
+ Misses        213      205       -8     
+ Partials      196      187       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Danipiza Danipiza changed the title [#24620] Added regression tests [#24620] Added regression tests for DDS-Pipe Dispose fix in DDS-Router repeater Jun 19, 2026
@Danipiza Danipiza merged commit 1a0f4ad into main Jun 19, 2026
25 of 36 checks passed
@Danipiza Danipiza deleted the fix/dispose branch June 19, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants