Support targeting specific instances#3958
Open
peterschmidt85 wants to merge 1 commit into
Open
Conversation
cc1de31 to
b6c0de7
Compare
jvstme
reviewed
Jun 12, 2026
b6c0de7 to
3258c39
Compare
3258c39 to
556c94e
Compare
Co-authored-by: Federico D'Agostino <fede.dagos@gmail.com>
556c94e to
c1d9fa9
Compare
jvstme
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a strict
instancesschema for runs so users can target existing fleet instances explicitly:instances: [my-fleet-1]instances: [{name: my-fleet-1}]instances: [{hostname: worker-1}]instances: [{fleet: my-fleet, instance: 1}], includingproject/fleetCompared to #3925, this PR keeps the normal fleet selection path mostly unchanged. The new selector resolution and targeted reusable-instance assignment path is used only when
instancesis set; missing targets fail without provisioning new capacity.Testing
Automated:
uv run --no-sync pytest src/tests/_internal/core/models/test_profiles.py src/tests/_internal/server/services/test_instances.py src/tests/_internal/server/services/runs/test_plan.py src/tests/_internal/server/background/pipeline_tasks/test_submitted_jobs.py -q(100 passed, 77 skipped)uv run --no-sync ruff check ...uv run --no-sync pyright -p .git diff --checkE2E:
t2.smallinstances:instancesnamehostnameusing a service{fleet, instance}All E2E AWS resources were cleaned up after verification.
AI Assistance: implemented and tested with Codex.