Remove the orphaned Qt-era island bundles from assets/ - #336
Merged
Conversation
The Qt architecture gave each webview its own fully self-contained Vite bundle under assets/<island>/, which graphlink_composer_web.py inlined into a single offline HTML document. R7.6a replaced all 19 islands with the SPA and deleted their source, their build registry, and that consumer module - but left the compiled output committed. Nothing referenced the leftovers: no Python, TypeScript, HTML, or build config mentions them; the backend's own /assets mount points at web_ui/dist/app/assets, not the repo root; and no build target regenerates them. Removes 19 directories of built JS/CSS/HTML plus four static files orphaned by the same migration - the Qt stylesheet images (a combobox arrow and a checkbox indicator), a file glyph, and the Qt splash audio. assets/graphlink.ico and assets/branding/ are untouched: the desktop shell and tools/build_app_icon.py both still use them. .gitattributes drops its web_ui/src/islands/*/index.html rule, whose path no longer exists, and the assets/*/** rule keeps its behaviour with a corrected comment - it now covers the surviving assets/branding/ and assets/screenshots/ rather than island build output. Repo-only weight: pyproject packages just backend* and graphlink_plugins*, so none of this shipped in the wheel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under the Qt architecture, each webview hosted its own fully self-contained Vite bundle under
assets/<island>/, whichgraphlink_composer_web.py's_inline_bundle()inlined into a single offline HTML document.R7.6a replaced all 19 islands with the SPA and deleted their source (
web_ui/src/islands/), the 19-entry build registry invite.config.ts, and that consumer module — but the compiled output stayed committed.vite.config.tsstill records what happened:Change
Deletes the 19 leftover bundle directories, plus four static files orphaned by the same migration: the two Qt stylesheet images (
down_arrow.pngfor combobox arrows,check.pngfor checkbox indicators),File.png, and the Qt splash audio..gitattributesdrops itsweb_ui/src/islands/*/index.htmlrule, whose path no longer exists. Theassets/*/**rule is kept with its behaviour unchanged and its comment corrected — it now covers the survivingassets/branding/andassets/screenshots/rather than island build output.Untouched:
assets/graphlink.ico(used bygraphlink_desktop.pyandtools/build_app_icon.py) andassets/branding/(used bybuild_app_icon.pyandgl-vars-dev.css).This is repo-only weight —
pyproject.tomlpackages onlybackend*andgraphlink_plugins*, so none of it shipped in the wheel.Evidence it was dead
.gitattributesrule and two gitignored/doc/planning filesapp.mount("/assets", …)points atweb_ui/dist/app/assets, not the repo rootsrc/appis the only build targetgraphlink_composer_web.pydeletedTest plan
ruffcleangraphlink_desktop.py's icon path still resolves;tools/build_app_icon.pystill runs.gitattributesrule verified to still match real tracked files (20 / 26 / 1)