Skip to content

Remove the orphaned Qt-era island bundles from assets/ - #336

Merged
dovvnloading merged 1 commit into
mainfrom
chore/remove-qt-island-bundles
Aug 18, 2026
Merged

Remove the orphaned Qt-era island bundles from assets/#336
dovvnloading merged 1 commit into
mainfrom
chore/remove-qt-island-bundles

Conversation

@dovvnloading

Copy link
Copy Markdown
Owner

Problem

Under the Qt architecture, each webview hosted its own fully self-contained Vite bundle under assets/<island>/, which graphlink_composer_web.py's _inline_bundle() inlined into a single offline HTML document.

R7.6a replaced all 19 islands with the SPA and deleted their source (web_ui/src/islands/), the 19-entry build registry in vite.config.ts, and that consumer module — but the compiled output stayed committed. vite.config.ts still records what happened:

"This config used to carry a 19-entry ISLANDS registry and a GRAPHLINK_ISLAND env switch… R7.6a deleted every island — the SPA replaced all 19 — so the switch, the registry, and the per-island outDir have nothing left to select between."

Change

Deletes the 19 leftover bundle directories, plus four static files orphaned by the same migration: the two Qt stylesheet images (down_arrow.png for combobox arrows, check.png for checkbox indicators), File.png, and the Qt splash audio.

.gitattributes drops its web_ui/src/islands/*/index.html rule, whose path no longer exists. The assets/*/** rule is kept with its behaviour unchanged and its comment corrected — it now covers the surviving assets/branding/ and assets/screenshots/ rather than island build output.

Untouched: assets/graphlink.ico (used by graphlink_desktop.py and tools/build_app_icon.py) and assets/branding/ (used by build_app_icon.py and gl-vars-dev.css).

This is repo-only weight — pyproject.toml packages only backend* and graphlink_plugins*, so none of it shipped in the wheel.

Evidence it was dead

Check Result
Code references to any of the 19 None — only a .gitattributes rule and two gitignored /doc/ planning files
Backend serves them? No — app.mount("/assets", …) points at web_ui/dist/app/assets, not the repo root
Any build regenerates them? No — the SPA under src/app is the only build target
Consumer module graphlink_composer_web.py deleted
Live PySide6 imports Zero
Tracked references to the four static files Zero

Test plan

  • Full backend suite: 3020 passed, 17 skipped
  • Full frontend check: 1944 tests, zero lint errors, build and bundle size clean
  • ruff clean
  • graphlink_desktop.py's icon path still resolves; tools/build_app_icon.py still runs
  • Every remaining .gitattributes rule verified to still match real tracked files (20 / 26 / 1)

The Qt architecture gave each webview its own fully self-contained Vite
bundle under assets/<island>/, which graphlink_composer_web.py inlined
into a single offline HTML document. R7.6a replaced all 19 islands with
the SPA and deleted their source, their build registry, and that
consumer module - but left the compiled output committed.

Nothing referenced the leftovers: no Python, TypeScript, HTML, or build
config mentions them; the backend's own /assets mount points at
web_ui/dist/app/assets, not the repo root; and no build target
regenerates them. Removes 19 directories of built JS/CSS/HTML plus four
static files orphaned by the same migration - the Qt stylesheet images
(a combobox arrow and a checkbox indicator), a file glyph, and the Qt
splash audio.

assets/graphlink.ico and assets/branding/ are untouched: the desktop
shell and tools/build_app_icon.py both still use them.

.gitattributes drops its web_ui/src/islands/*/index.html rule, whose
path no longer exists, and the assets/*/** rule keeps its behaviour with
a corrected comment - it now covers the surviving assets/branding/ and
assets/screenshots/ rather than island build output.

Repo-only weight: pyproject packages just backend* and
graphlink_plugins*, so none of this shipped in the wheel.
@dovvnloading
dovvnloading merged commit 39ab46f into main Aug 18, 2026
4 checks passed
@dovvnloading
dovvnloading deleted the chore/remove-qt-island-bundles branch August 18, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant