Revert canvas rendering changes from #322, #323 and #324 - #325
Merged
Conversation
These three changes were attempts at the drag artifact that were not confirmed to work before shipping, and the most recent one made things worse: with #324 in place the connection lag became visible in the light theme as well, where it had previously been unnoticeable. The most likely cause of that regression is the composition flag. The audit behind #324 established that the flag added in #323 never reached the browser, because the window library passes a conflicting switch and duplicate switches resolve last-one-wins. #324 corrected the delivery, so disabling delegated composition took effect for the first time - and it applies to both themes equally, which matches the report exactly. The stroke width increase and the explicit high-quality smoothing hint in the same change also affect both themes and cannot be ruled out. This restores graphlink_desktop.py, styles.css and gl-vars-dev.css to their state as of #321. The measured performance fixes in #319, #320 and #321 are untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three changes aimed at the connection-lag-while-dragging artifact were shipped without confirmed reproduction of a fix. The most recent, #324, made the situation worse: the lag became visible in the light theme too, where it had previously gone unnoticed.
The most likely cause is the composition flag. The audit behind #324 found that the flag introduced in #323 never reached the browser, because the window library passes a conflicting switch and duplicate switches resolve last-one-wins. #324 corrected that delivery, so disabling delegated composition took effect for the first time. It applies to both themes equally, which matches the report. The stroke width increase and explicit smoothing hint in the same change also affect both themes and cannot be ruled out as contributors.
Change
Restores
graphlink_desktop.py,web_ui/src/app/styles.cssandweb_ui/src/lib/tokens/gl-vars-dev.cssto their state as of #321. This removes: the layer promotion hints (#322), the composition flag (#323 and #324), the connection stroke colour token and width and smoothing change (#324), the dark shadow values matching light (#324), and the page root background (#324).The measured performance fixes in #319, #320 and #321 are untouched.
Test plan