Improve and simplify the IConsoleService interface#5924
Open
mikem8361 wants to merge 2 commits into
Open
Conversation
hoyosjs
reviewed
Jul 13, 2026
| { | ||
| public enum OutputType | ||
| { | ||
| Normal = 0, |
Member
There was a problem hiding this comment.
These feel a little orthogonal - one is about the verbosity, while the other is about the output style.
Contributor
Author
There was a problem hiding this comment.
It matches the old functions Write, WriteWarning, WriteErrorLine, etc. I guess it is including both into one type to be able to funnel all the output through one function.
hoyosjs
reviewed
Jul 13, 2026
| int WindowWidth { get; } | ||
| /// <param name="type">type of text to write</param> | ||
| /// <param name="text">text to write</param> | ||
| void WriteString(OutputType type, string text); |
Member
There was a problem hiding this comment.
If the console service now has an output type of DML - why do callers need SupportsDml? That being said - given the output content changes based on dml or not - the supportsdml feels necessary.
mikem8361
force-pushed
the
betterconsoleservice
branch
from
July 13, 2026 22:44
4e0fa30 to
a325cfa
Compare
mikem8361
force-pushed
the
betterconsoleservice
branch
2 times, most recently
from
July 19, 2026 17:24
7a82dbf to
219e2de
Compare
Combined all the explicit Write functions into one function with the output type. First step in improving the overall (managed and native) console infrastructure.
mikem8361
force-pushed
the
betterconsoleservice
branch
from
July 24, 2026 19:12
d79c1ee to
af20448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined all the explicit Write functions into one function with the output type.
First step in improving the overall (managed and native) console infrastructure.