Fix dev-certs EventSource Boolean payload - #68138
Open
HengYpinn wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your PR, @HengYpinn. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an EventSource contract mismatch in CertificateManagerEventSource.ExportCertificateStart where a bool parameter was emitted as a string payload, ensuring consumers receive the expected Boolean value.
Changes:
- Update
ExportCertificateStartto write theincludePrivateKeyBoolean directly toWriteEvent. - Adjust the event message format to reflect the Boolean payload.
- Add regression tests validating the payload type/value for both
trueandfalse.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/CertificateGeneration/CertificateManager.cs | Corrects EventSource payload type for ExportCertificateStart and updates the message format accordingly. |
| src/Shared/test/Shared.Tests/CertificateManagerEventSourceTests.cs | Adds regression coverage to validate the event payload includes a Boolean for includePrivateKey and isolates tests via a non-parallelized collection. |
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the dev-certs EventSource Boolean payload
Description
CertificateManagerEventSource.ExportCertificateStartdeclaresincludePrivateKeyas a Boolean, but passed"with"or"without"toWriteEvent. EventSource consumers therefore received a string payload that did not match the event contract.This change writes the Boolean value directly, updates the event message to format that value, and adds regression coverage for both
trueandfalsepayloads.Testing
Passed: 1,329; Failed: 0; Skipped: 0.
Fixes #29541