Fix build warnings in MSBuildDeviceIntegration project#11980
Open
simonrozsival wants to merge 1 commit into
Open
Fix build warnings in MSBuildDeviceIntegration project#11980simonrozsival wants to merge 1 commit into
simonrozsival wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a duplicate using System.Globalization; in InlineData.cs which was producing CS0105 when the MSBuildDeviceIntegration test project links in the shared Utilities sources, and it tightens CI enforcement by no longer grandfathering warnings for MSBuildDeviceIntegration.csproj.
Changes:
- Remove the duplicate
using System.Globalization;to eliminate CS0105 inInlineData.cs. - Remove the
MSBuildDeviceIntegration.csprojexemption from_AllowProjectWarningsso warnings are no longer permitted for that project.
Show a summary per file
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/InlineData.cs | Removes the duplicate System.Globalization using that triggered CS0105. |
| Directory.Build.props | Stops allowing warnings in MSBuildDeviceIntegration.csproj, ensuring future warnings are treated as errors on CI. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
simonrozsival
added
the
ready-to-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following warning: