Fix build warnings in jnienv-gen project#11977
Open
simonrozsival wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a previously grandfathered warning exemption for the jnienv-gen project by eliminating the underlying unused Prebind field and its associated dead code paths in the generator, so the project can build cleanly with warnings treated as errors on CI.
Changes:
- Remove the
jnienv-gen.csprojcarve-out from_AllowProjectWarnings, allowing CI’sTreatWarningsAsErrorsbehavior to apply. - Delete the unused
JniFunction.Prebindfield and simplifyGenerateJniNativeInterfaceInvokerto always emit the lazy-initialization property form.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Removes the jnienv-gen warning allowance so CI treats warnings as errors for the project. |
| build-tools/jnienv-gen/Generator.cs | Removes the unused Prebind flag and simplifies generated invoker delegate binding code accordingly. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the following build warning:
Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include: