Skip to content

[Tests] Retry flaky InstallAndroidDependenciesTest download #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonrozsival wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −6
Open

[Tests] Retry flaky InstallAndroidDependenciesTest download #11974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions ...Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.IO;
using System.Linq;
using System.Text;
using System.Threading;
using System.Xml;
using System.Xml.Linq;
using NUnit.Framework;
Expand Down Expand Up @@ -43,11 +44,6 @@ public void InstallAndroidDependenciesTest ([Values ("GoogleV2", "Xamarin")] str
string jdkPath = Path.Combine (Root, "temp", TestName, "android-jdk");
Environment.SetEnvironmentVariable ("TEST_ANDROID_SDK_PATH", sdkPath);
Environment.SetEnvironmentVariable ("TEST_ANDROID_JDK_PATH", jdkPath);
foreach (var path in new [] { sdkPath, jdkPath }) {
if (Directory.Exists (path))
Directory.Delete (path, recursive: true);
Directory.CreateDirectory (path);
}

var proj = new XamarinAndroidApplicationProject {
IsRelease = isRelease,
Expand All @@ -69,7 +65,30 @@ public void InstallAndroidDependenciesTest ([Values ("GoogleV2", "Xamarin")] str
string defaultTarget = b.Target;
b.Target = "InstallAndroidDependencies";
b.BuildLogFile = "install-deps.log";
Assert.IsTrue (b.Build (proj, parameters: buildArgs.ToArray ()), "InstallAndroidDependencies should have succeeded.");

// InstallAndroidDependencies downloads the Android SDK and JDK over the network, which
// can fail intermittently in CI. Retry a few times before giving up, starting from a
// clean SDK/JDK directory each attempt so a partial download does not affect the next.
// See https://github.com/dotnet/android/issues/11973
const int maxInstallAttempts = 3;
bool installSucceeded = false;
for (int attempt = 1; attempt <= maxInstallAttempts; attempt++) {
foreach (var path in new [] { sdkPath, jdkPath }) {
if (Directory.Exists (path))
Directory.Delete (path, recursive: true);
Directory.CreateDirectory (path);
}

if (b.Build (proj, parameters: buildArgs.ToArray ())) {
installSucceeded = true;
break;
}

TestContext.WriteLine ($"InstallAndroidDependencies attempt {attempt} of {maxInstallAttempts} failed. Please check the task output in 'install-deps.log'.");
if (attempt < maxInstallAttempts)
Thread.Sleep (TimeSpan.FromSeconds (10));
}
Assert.IsTrue (installSucceeded, $"InstallAndroidDependencies should have succeeded within {maxInstallAttempts} attempts.");
Comment on lines +69 to +91

// When dependencies can not be resolved/installed a warning will be present in build output:
// Dependency `platform-tools` should have been installed but could not be resolved.
Expand Down
Loading