[tests] Re-enable AndroidMessageHandler ServerCertificateCustomValidationCallback tests#11972
Open
simonrozsival wants to merge 1 commit into
Conversation
…tionCallback tests These five `ServerCertificateCustomValidationCallback_*` device tests were `[Ignore]`d in dotnet#11801 because a boolean-returning SSL validation callback crashed the test process with a native SIGSEGV under the trimmable typemap (CoreCLR/NativeAOT) mid-handshake. The root cause was fixed in dotnet#11802: the trimmable typemap generator now matches each `n_*` callback `MemberRef` to its binding's real boolean/char signature, so the `[UnmanagedCallersOnly]` forwarder no longer "always throws" and the callback dispatches correctly. Verified locally on an arm64 emulator with `-p:_AndroidTypeMapImplementation=trimmable -p:UseMonoRuntime=false`: all five re-enabled tests (plus the never-ignored `NoServerCertificateCustomValidationCallback_*`) pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
added
copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables previously ignored on-device SSL tests for AndroidMessageHandler.ServerCertificateCustomValidationCallback_*, restoring coverage for certificate validation callback behavior now that the underlying trimmable-typemap crash has been addressed upstream.
Changes:
- Removes
[Ignore]from fiveServerCertificateCustomValidationCallback_*device tests so they run again under the SSL test fixture category.
Show a summary per file
| File | Description |
|---|---|
| tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerTests.cs | Removes [Ignore] attributes to re-enable five SSL callback device tests. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
simonrozsival
added
the
ready-to-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables the five
AndroidMessageHandler.ServerCertificateCustomValidationCallback_*device tests that were[Ignore]d in #11801.They were disabled because a boolean-returning SSL validation callback crashed the test process with a native SIGSEGV under the trimmable typemap (CoreCLR/NativeAOT) mid-handshake:
ServerCertificateCustomValidationCallback_ApproveRequestServerCertificateCustomValidationCallback_RejectRequestServerCertificateCustomValidationCallback_ApprovesRequestWithInvalidCertificateServerCertificateCustomValidationCallback_IgnoresCertificateHostnameMismatchServerCertificateCustomValidationCallback_RedirectsWhy they pass now
The root cause was fixed in #11802: the trimmable typemap generator now matches each
n_*callbackMemberRefto its binding's real boolean/char signature, so the[UnmanagedCallersOnly]forwarder no longer "will always throw" and the SSL validation callback dispatches correctly.Verification
Built the local SDK on top of current
main(which includes both #11802 and the reflection-free trimmable managers from #11801) and ran theSSL-category device tests on an arm64 emulator with-p:_AndroidTypeMapImplementation=trimmable -p:UseMonoRuntime=false.All five re-enabled tests pass (as does the never-ignored
NoServerCertificateCustomValidationCallback_ThrowsWhenThereIsCertificateHostnameMismatch); overall SSL run: 0 failed. CI validates the full runtime matrix (CoreCLR / Mono / CoreCLRTrimmable / NativeAOT).