fix: add Emacs 30 compatibility for closql - #7
Open
ArthurHeymans wants to merge 1 commit into
Open
Conversation
In Emacs 30, closql--coerce may return an eieio--class struct instead of a class symbol in slot 0 when converting objects to lists. This causes closql--abbrev-class to fail with 'wrong-type-argument sequencep'. Add advice to convert the class struct to its symbol name before closql--abbrev-class processes it. The fix only applies on Emacs 30+.
|
Tested manually, it works for me. @ArthurHeymans |
|
I don't think this fixes the problem for me. Please tell me if I'm doing something wrong. I'm loading this branch with (use-package code-review
:vc (:url "https://github.com/ArthurHeymans/code-review" :branch "Emacs30ClosqlCompat" :rev :newest)
:after forge
:bind (:map forge-topic-mode-map
("C-c r" . code-review-forge-pr-at-point)))and I've checked that I'm using Emacs 30.2 installed from snap in Ubuntu. |
ykoor
pushed a commit
to ykoor/code-review
that referenced
this pull request
Aug 7, 2026
…elpa#5, doomelpa#7) - doomelpa#10: load ghub-legacy when ghub-graphql is not already defined, restoring compatibility with ghub 5.1 while keeping older releases working. - doomelpa#8 and doomelpa#5: fix the payload structure in code-review-send-labels (vector of label names, correct post/put choice). - doomelpa#7 (amended): instead of advising closql--abbrev-class, advise closql--coerce and closql--remake-instance to replicate closql 2.4.0's Emacs 30 handling of EIEIO records. The original advice only covered one call site of the same root cause. Verified on Emacs 30.2 with closql 2.3.2 and 2.4.1, with eieio-backward-compatibility both enabled and disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Emacs 30, closql--coerce may return an eieio--class struct instead
of a class symbol in slot 0 when converting objects to lists. This
causes closql--abbrev-class to fail with 'wrong-type-argument sequencep'.
Add advice to convert the class struct to its symbol name before
closql--abbrev-class processes it. The fix only applies on Emacs 30+.