store: replace namesgenerator with neutral builder IDs#3955
Closed
lancefrench wants to merge 1 commit into
Closed
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Author
|
Uh, overeager robot. 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining
github.com/docker/dockerdependency from Buildx.Buildx already uses the Moby API and client modules; this removes its only legacy import,
github.com/docker/docker/pkg/namesgenerator, by using a neutralbuilder_prefix and a BuildKit-generated ID suffix.This refreshes the approved approach from #3813 on current
master, with regenerated module and vendor metadata.Validation:
go test ./storego build ./cmd/buildxgo mod graph | rg github.com/docker/dockerreturns onlydocker-credential-helpers, not the legacy Docker daemon module.