[DIT-13468]: Send scanned path scope in the CLI scan - #156
Open
laurakoye wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
ditto scannow tells the server where it looked, so a later scan only reconciles code links inside the scanned scope instead of assuming everything it didn't see was deleted.Two fields on
POST /v2/scan, alongside therepoRelativeRootthat shipped in #155:repoRelativeRootscannedAllPathsscannedPaths""truesrc"src"false["src"]scannedPathsentries are relative to the repo root, matching what ditto-app #9391 validates. Where the scope is omitted, the server'sscannedAllPaths: falsedefault applies, so such a scan can never mark a code link removed.ditto scantakes one path, soscannedPathsis always a one-element list restatingrepoRelativeRoot. Sent anyway so DIT-13449's reconcile has one shape to code against.Bumps the package to 5.8.1 — nothing user-visible changes.
Context
Test Plan
Against a local app on the #9391 branch. Records checked in Compass:
ditto_db_v2→producttextdetections, filter{ repoKey: { $exists: true } }.yarn test lib/src/http/scan.test.tsyarn scan ~/Desktop/Ditto/v0-demo→repoRelativeRoot: "",scannedAllPaths: true, noscannedPathsyarn scan ~/Desktop/Ditto/v0-demo/src→repoRelativeRoot: "src",scannedAllPaths: false,scannedPaths: ["src"]yarn scan /tmp/not-a-repo→ no git fields on the record