[DIT-13447] Introduce escape decoding on extractor level - #149
Merged
Conversation
joustrich
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduces handling specifically for escaped values like
\n,\t, etc.The root issue is that we encode the escape character to maintain the raw value, but never decode it when going to store it in Ditto. It's handled at the extractor level so that we can abide by certain per-language rules (for instance in kotlin a raw string
"""hello\nworld""", the\nwould be intended to show.Also addresses an issue found during testing for android xml specifically where tags were throwing off some of the parsing
Context
Screenshots
Test Plan
yarn scanworks as intended against https://github.com/dittowords/ditto-android-demo\n,\t,\\netc to the code you're scanning that's a bonus, but I think the unit tests cover that logic pretty well.