Patch optimizer rework - #143
Merged
Merged
Conversation
(1) FloatTree was a bad name for this abstraction as it did not require V to be a Floating, renamed to TreeOf and implemented correctly: If no float required V; if float required V: IsFloating. Added test for TreeOf with Int32 (2) Update optimizers changing constructor values to Tensor0[Float32] moving precision to init and update method making precision depend on params. Optimizers don't carry a precision, they adapt to the parameters' precision.
benikm91
force-pushed
the
rework-optimizer-patch
branch
from
August 11, 2026 12:42
dfe3078 to
464609b
Compare
marcelluethi
approved these changes
Aug 11, 2026
marcelluethi
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks for fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found three issues when integrating new optimizers into the GPT example...
Solution: Remove default values and have a constructor with Double for the common case.
vs.
I hope this fixes it enough that we don't run into more issues.