Skip to content

Update dfetch environment to show newer version inline#1310

Merged
spoorcc merged 2 commits into
mainfrom
new-version-print
Jun 25, 2026
Merged

Update dfetch environment to show newer version inline#1310
spoorcc merged 2 commits into
mainfrom
new-version-print

Conversation

@spoorcc

@spoorcc spoorcc commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Improvements
    • dfetch environment now shows the installed version and (when applicable) the newer available version inline on the same line, including a direct link to the release page.
  • Documentation
    • Updated CHANGELOG.rst with an unreleased “Release 0.14.3” entry describing the updated version output.
  • Tests
    • Adjusted the environment information feature expectations to match the new inline “newer version + link” formatting.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fdc6d868-5cac-4a47-8fcb-3e5ffc2688d4

📥 Commits

Reviewing files that changed from the base of the PR and between f3c4f29 and b778d2f.

📒 Files selected for processing (3)
  • CHANGELOG.rst
  • dfetch/commands/environment.py
  • features/environment.feature
 ___________________________________________________________________
< It's elementary, my dear Watson. The bugs are hiding in the code. >
 -------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

Environment.__call__ now checks for a newer version first and prints one inline dfetch report line with the version, newer-version text, and releases URL. The environment feature expectation and changelog entry were updated to match.

Changes

Inline newer version in dfetch environment output

Layer / File(s) Summary
Consolidated version report line and test update
dfetch/commands/environment.py, features/environment.feature, CHANGELOG.rst
Environment.__call__ replaces separate version and newer-version notice output with one print_report_line("dfetch", dfetch_info) call. The feature scenario now expects the inline parenthesized newer-version text, and the changelog adds a Release 0.14.3 unreleased note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • dfetch-org/dfetch#1262: Modifies the same Environment.__call__ flow around newer_version_available() and the dfetch environment version notice formatting.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: dfetch environment now shows the newer version inline.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new-version-print

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@spoorcc

spoorcc commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ben-edna

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.rst`:
- Line 4: Replace the placeholder PR reference in the changelog entry with the
actual PR or issue number. Update the “Update ``dfetch environment`` to show
newer version inline” item in CHANGELOG.rst to use the real reference instead of
`#0` so the release note is traceable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3097c455-cb17-44ff-ae80-6dc01e92872e

📥 Commits

Reviewing files that changed from the base of the PR and between a7d20b8 and 501ad4e.

📒 Files selected for processing (3)
  • CHANGELOG.rst
  • dfetch/commands/environment.py
  • features/environment.feature

Comment thread CHANGELOG.rst Outdated
spoorcc and others added 2 commits June 25, 2026 22:04
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@spoorcc spoorcc merged commit fb6ac2a into main Jun 25, 2026
36 checks passed
@spoorcc spoorcc deleted the new-version-print branch June 25, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants