fix(search): keep curated indexes consistent - #2
Open
kaykayyali wants to merge 6 commits into
Open
Conversation
added 4 commits
July 20, 2026 07:21
Replace obsolete same-path identities, prune out-of-vault and hidden notes, and accept filename stems when auditing Obsidian links. Closes devnill#1
Delegate shared curation pruning to the FTS layer and harden hidden-path checks against symlink aliases and loops.
Remove invalid semantic keys and fail closed at query time so Hybrid search cannot resurrect pruned notes.
USearch 2.23 names the result-count parameter count; using k silently disabled semantic search behind the fallback path.
kaykayyali
force-pushed
the
fix/issue-1-search-index-consistency
branch
from
July 20, 2026 07:54
7be9b13 to
ccb5f8b
Compare
added 2 commits
July 20, 2026 08:16
Reuse the guarded GrepBackend for public recall so an empty index result cannot resurrect hidden or out-of-vault notes.
Filter indexed paths through the active-vault guard so a fresh scan marker cannot expose a hidden stale row through public recall.
Author
|
Independent immutable-head review approved The review traced every public Final deployed verification:
Ready for an upstream maintainer to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.trashand test data cannot remain searchablecountquery parameter so semantic search actually runsWhy
Vault curation can change a note's identity or move notes into hidden folders while the physical file still exists. The search index previously retained obsolete rows, and Hybrid/auto could bypass or semantically resurrect them. Audit relation checks also treated filename-based wikilinks as broken when frontmatter titles differed.
Tests
uv run pytest tests/ -quv run ruff check src/cyberbrain/extractors/search_backends.py src/cyberbrain/mcp/tools/{audit,recall}.py tests/{test_audit,test_mcp_server,test_search_backends}.pycb_recallprobe: a term present only in.trashreturnedNo notes foundNo notes found, then cleanup restored index parityCloses #1