Fix buffer stride runtime mismatch

[mloubout]

Make sure mapped array use symbolic padding so that it always matches the runtime mapped function and can safely reuse the Function's strydes.

[codecov]

Codecov Report

❌ Patch coverage is 37.77778% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.16%. Comparing base (58df797) to head (adaaa94).

Files with missing lines	Patch %	Lines
devito/types/array.py	35.48%	19 Missing and 1 partial ⚠️
devito/types/basic.py	50.00%	3 Missing ⚠️
devito/passes/clusters/buffering.py	0.00%	2 Missing ⚠️
devito/types/dense.py	33.33%	1 Missing and 1 partial ⚠️
devito/passes/iet/linearization.py	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (58df797) and HEAD (adaaa94). Click for more details.

HEAD has 27 uploads less than BASE

Flag	BASE (58df797)	HEAD (adaaa94)
	18	1
pytest-gpu-gcc-	6	1
pytest-gpu-icx-	3	0
pytest-gpu-nvc-nvidiaX	1	0
pytest-gpu-aomp-amdgpuX	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2950       +/-   ##
===========================================
- Coverage   83.47%   59.16%   -24.32%     
===========================================
  Files         249      195       -54     
  Lines       52276    33783    -18493     
  Branches     4503     3945      -558     
===========================================
- Hits        43638    19988    -23650     
- Misses       7880    12842     +4962     
- Partials      758      953      +195     

Flag	Coverage Δ
pytest-gpu-aomp-amdgpuX	?
pytest-gpu-gcc-	55.39% <37.77%> (-22.83%)	⬇️
pytest-gpu-icx-	?
pytest-gpu-nvc-nvidiaX	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[FabioLuporini]

random thought: do we need a dimensions_padded property rather than just [-1]? thinking about what we recently doing in PRO with all those "special" Arrays.

[mloubout]

At some point yes would be good to have

[FabioLuporini]

with this fix, can we also drop this:

https://github.com/devitocodes/devito/blob/main/devito/types/misc.py#L270-L274

?

[mloubout]

I think so yes

[FabioLuporini]

some questions, but it's a great catch, and a great cleanup too

[EdCaunt]

Approved pending Fabio's comments