fix(devframe): add force? param to RpcFunctionsCollector register/update#91
Merged
Conversation
The RpcFunctionsCollector interface omitted the force? argument that the concrete RpcFunctionsCollectorBase class and its runtime already support. Because the client-side host is typed off the interface (via DevframeClientRpcHost), calling register(fn, true) / update(fn, true) on the client was a type error and required a cast even though it works at runtime. Align the interface with the implementation.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the optional
force?: booleanparameter toregisterandupdateon theRpcFunctionsCollectorinterface so it matches its concrete implementation.Why
RpcFunctionsCollectorBase.register()/.update()already accept a secondforce?: booleanargument, and the runtime honors it (force: trueoverwrites, skipping DF0021/DF0022). The server-sideRpcFunctionsHostis typed off the concrete class, so it typesforcecorrectly.The client-side host, however, is typed off the
RpcFunctionsCollectorinterface (viaDevframeClientRpcHost = RpcFunctionsCollector<…>), which declaredregister/updatewithoutforce. As a result, callingclient.register(fn, true)on the client was a type error ("Expected 1 arguments, but got 2.") and required a cast, even though it works at runtime.Aligning the interface with the implementation lets client-side
register(fn, true)/update(fn, true)type-check without a cast.Verified with
pnpm typecheck,pnpm test(652 passing, API snapshot unchanged).This PR was created with the help of an agent.