Update express version#700
Open
yaroslav8765 wants to merge 5 commits into
Open
Conversation
AdminForth/1780/add-support-of-expiry-in-kv-ad
…ress-version AdminForth/1781/image
AdminForth/1781/image
AdminForth/1781/image
AdminForth/1781/image
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project to support newer Express versions (including Express 5) while keeping compatibility with Express 4, and refreshes lockfiles to reflect the dependency upgrades.
Changes:
- Bumped Express in the dev demo to
4.22.2. - Updated
adminforthto acceptexpresspeer dependency^4.21.0 || ^5.0.0, and upgraded@types/expressto v5 types. - Adjusted
ExpressServerto handle Express 5 routing differences (wildcard route patterns, router stack access) and added logging of the resolved Express version.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| dev-demo/pnpm-lock.yaml | Locks dev demo to Express 4.22.2 and updated transitive deps. |
| adminforth/servers/express.ts | Adds Express-version-aware routing behavior and logging. |
| adminforth/pnpm-lock.yaml | Updates lockfile to Express 5.2.1 + updated transitive deps and Express v5 typings. |
| adminforth/package.json | Moves express to peer deps with a dual-range and updates @types/express to v5. |
| adminforth/commands/createApp/templates/package.json.hbs | Updates scaffolded apps to use Express ^5.2.1 and @types/express v5. |
Files not reviewed (2)
- adminforth/pnpm-lock.yaml: Generated file
- dev-demo/pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.