Clarify package.json vs deno.json for Deno Desktop frameworks - #3458
Open
Rohan170603 wants to merge 1 commit into
Open
Clarify package.json vs deno.json for Deno Desktop frameworks#3458Rohan170603 wants to merge 1 commit into
Rohan170603 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Framework projects scaffolded with
deno init --npmgenerate apackage.json, but thedesktopmanifest key that Deno Desktop expects does not belong there. Developers are unsure whether to keep both files, fold one into the other, or where to put desktop configuration.Solution
package.jsondeclares npm dependencies anddeno.jsonconfigures Deno-specific settings, including thedesktopmanifest.desktopkey inpackage.json.Changes
runtime/desktop/frameworks.mdto include the new section, example, and FAQ.Checklist
package.jsonanddeno.json.package.jsondesktop keys are ignored.last_modifieddate.Closes #3379.