fix(examples): repair dead links and prose typos - #3452
Conversation
Avocet review statusState: Completed The formal GitHub review is the authoritative result. This comment only reports operational status. |
avocet-bot
left a comment
There was a problem hiding this comment.
Review model: Claude Opus
Model verdict: APPROVE (informational only)
Formal review policy did not authorize an authoritative event (required_checks_missing).
No blocking findings. This is a documentation-only change to @resource links and JSDoc prose across example scripts. I verified every changed link against the repo (which serves docs.deno.com): all eight external doc paths resolve to existing files/anchors — runtime/getting_started/{installation,setup_your_environment}.md, deploy/reference/cron.md, deploy/kv/index.md (old /deploy/kv/manual is now an oldUrl), deploy/classic/queues.md (fixes the class9c→classic typo), deploy/classic/api/runtime-broadcast-channel.md, runtime/reference/cli/bench.md, and the #use-a-node-built-in-module heading anchor in node.md. Internal /examples/ links were corrected to the underscore convention (writing_files, http_server_routing) and to module_metadata_tutorial (confirmed by the tutorial's frontmatter url: and _data.ts); the removed hyphenated dependency-management link pointed to a nonexistent example. Prose fixes (anytime→any time, a HTTP→an HTTP, duplicated "the", Uploadinf→Uploading, hello: word→world, stray * out) are all correct with no leftovers. No code, tests, error handling, or types are affected.
Avocet review statusState: Completed The formal GitHub review is the authoritative result. This comment only reports operational status. |
avocet-bot
left a comment
There was a problem hiding this comment.
Review model: Claude Opus
Model verdict: APPROVE
No blocking findings. The current head is a merge of main into the branch; the exact base/head diff is identical to the previously reviewed head (same 30 files, same edits), and the only delta between the two heads is examples/tutorials/sveltekit.md, which came from main and is identical in base and head (not part of this changeset). All prior verification still holds: the eight changed docs.deno.com links resolve to existing files/anchors in this repo (which serves docs.deno.com) — runtime/getting_started/{installation,setup_your_environment}.md, deploy/reference/cron.md, deploy/kv/index.md (old /deploy/kv/manual is now its oldUrl), deploy/classic/queues.md (fixes class9c→classic), deploy/classic/api/runtime-broadcast-channel.md, runtime/reference/cli/bench.md, and the #use-a-node-built-in-module anchor in node.md. Internal /examples/ links now use the underscore convention (writing_files, http_server_routing) and module_metadata_tutorial (confirmed via tutorial frontmatter and _data.ts); the removed hyphenated dependency-management link targeted a nonexistent example. Prose fixes are all correct. No code, tests, error handling, or types are affected.
c1ba57b to
f19f097
Compare
f19f097 to
72c5ea5
Compare
class9ctypo,module_metadata,Deno.ServeTlsOptions, fresh.deno.dev, codahale.comruntime/manual/...,deploy/kv/manual,/examples/*kebab-case, etc.)an HTTP,at any time,allows us,Uploading,use the, YAML output example, em-dash -> colonReplaced links verified live (HTTP 200);
deno fmtanddeno checkpass.