fix(examples): bump outdated npm dependencies - #3451
Conversation
Avocet review statusState: Completed The formal GitHub review is the authoritative result. This comment only reports operational status. |
avocet-bot
left a comment
There was a problem hiding this comment.
Review model: Claude Opus
Model verdict: APPROVE (informational only)
Formal review policy did not authorize an authoritative event (required_checks_missing).
No blocking findings. This bumps five example dependencies to newer majors and refreshes @resource links.
Verified:
- All target versions exist on npm and match the
deno.lockresolutions exactly: jose 6.2.9, mongodb 7.5.0, redis 6.2.1, openai 7.4.0, and express 4.22.2 (the currentlatest-4dist-tag). The added lockfile entries (transitive deps for each package) are consistent. - The
import OpenAI from "npm:openai@^7"default-import change is correct for the v7 SDK; the remaining bumps touch only stable API surfaces (jose SignJWT/jwtVerify, mongodb basic CRUD, redis createClient/set/get/sendCommand/quit, express minor). - Updated doc links resolve:
runtime/fundamentals/node.mdexists in-repo and the URLs return 200; the retainedmanual/node/npm_specifierslink still redirects fine. examples/_pages/examples_test.tsalready runsdeno checkon every example in CI, catching any API-surface regression from these bumps before merge.
Non-blocking nit: mongo.ts prose still reads "Using the Deno MongoDB client," though it now imports the official npm mongodb driver — consider rewording to match the switch away from deno.land/x/mongo.
Avocet review statusState: Completed The formal GitHub review is the authoritative result. This comment only reports operational status. |
avocet-bot
left a comment
There was a problem hiding this comment.
Review model: Claude Opus
Model verdict: APPROVE
No blocking findings. The only change to this PR's files since the previously reviewed head (c05536a) is the mongo.ts prose update from "Using the Deno MongoDB client" to "Using the official MongoDB driver, you can connect to a MongoDB database," which resolves the sole non-blocking nit from my prior review. The sveltekit.md edits appearing in the head-to-head diff originate from the merge of main, not this PR; the base/head manifest and git diff --stat confirm the net change remains the same six files (deno.lock plus five example scripts).
All prior verifications still hold: the bumped versions exist on npm and match the deno.lock resolutions exactly (jose 6.2.9, mongodb 7.5.0, redis 6.2.1, openai 7.4.0, express 4.22.2), the openai v7 default-import is correct, the retained API surfaces are stable, updated @resource links resolve, and examples/_pages/examples_test.ts deno checks every example in CI.
bb4af34 to
6bad074
Compare
6bad074 to
60c3c91
Compare
npm.ts: express 4.18.2 -> 4.22.2 (keeps@types/express@4)mongo.ts: mongodb 6.1.0 -> ^7creating_and_verifying_jwt.ts: jose 5.9.6 -> ^6redis.ts: redis ^4.5 -> ^6openai_chat_completion.ts: migrate off frozen deno.land/x module tonpm:openai@^7deno.lock updated with the new resolution; no unrelated changes. All files pass
deno checkanddeno fmt.