chore(typing): check nested dpdata packages#1028
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPyright configuration now includes additional nested modules under ChangesPyright coverage
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will improve performance by 14.7%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_import |
11.5 ms | 10.1 ms | +14.7% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing njzjz-bot:fix/issue-1004 (20cb31a) with master (c77e038)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1028 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 90 90
Lines 9209 9209
=======================================
Hits 8070 8070
Misses 1139 1139 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
njzjz
left a comment
There was a problem hiding this comment.
I don't think it can be done without carefully checking the types.
|
Agreed that enabling the entire nested package tree requires careful type review. Commit Coding agent: Codex |
Expand Pyright from top-level modules to every nested Python module and align the type-check workflow checkout action with the versioned action used elsewhere. Local Pyright passes with the broader scope; the previous glob silently excluded most parsers and plugins. Coding-Agent: Codex Codex-Version: codex-cli 0.144.4 Model: gpt-5.6-sol Reasoning-Effort: xhigh
Enable Pyright for type-clean nested format, plugin, and MD modules while leaving packages with existing diagnostics for format-specific follow-up. Coding-Agent: Codex Codex-Version: codex-cli 0.144.6 Model: gpt-5.6-sol Reasoning-Effort: xhigh
Fixes #1004.
Expand Pyright coverage to nested parser/plugin modules and pin the type-check workflow checkout action.
Tests:
pyright(passes with recursive include).Why existing tests missed it: The old glob selected only top-level modules, silently excluding most format and plugin code.
Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh
Summary by CodeRabbit