fix(#478): pin packageManager to pnpm@10.33.0 - #479
Merged
Conversation
Both first-time contributors this week were bitten by the missing pin: a different pnpm major computes the lockfile's recorded settings differently, so --frozen-lockfile mismatches (ERR_PNPM_LOCKFILE_CONFIG_MISMATCH) and a plain install rewrites pnpm-lock.yaml destructively — one submitted diff dropped the entire security overrides block. - package.json: packageManager pnpm@10.33.0 (matches the Dockerfile's corepack pin). pnpm's package-manager-strict default now errors clearly on the wrong major; corepack users get switched automatically. - workflows: drop the `version: 10` input from pnpm/action-setup — the action reads packageManager when the input is omitted, and errors if both are specified and differ. - CONTRIBUTING: document the pin, corepack enable, and never committing a regenerated lockfile. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #478.
Adds the missing
packageManagerpin that let two first-time contributors regeneratepnpm-lock.yamlincompatibly this week (one diff silently dropped the entire securityoverridesblock and downgraded esbuild).package.json:"packageManager": "pnpm@10.33.0"— matches the Dockerfile's corepack pin. pnpm'spackage-manager-strictdefault now fails fast with a clear message on the wrong major; corepack users get auto-switched.ci.yml,flake-hunt.yml,mem-bench.yml,release.yml): removed theversion: 10input frompnpm/action-setup— the action readspackageManagerwhen the input is omitted, and errors when both are specified and differ.CONTRIBUTING.md: documents the pin,corepack enable, and never committing a regenerated lockfile.Verified locally:
pnpm install --frozen-lockfile --ignore-scriptspasses with the pin in place (pnpm 10.33.0). CI on this PR exercises the workflow change itself.🤖 Generated with Claude Code