You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for this — you were first to pick up #471, and your instinct about the tricky part was genuinely right: the else-branch re-sanitizing the stored message when a verify update carries none is exactly the failure mode that a competing fix initially missed. Live verification confirmed js-debug's bind event omits message, and the merged fix (#476 + an amendment) handles it the same way you anticipated.
I'm closing this one in favor of #476, which arrived with unit tests and covered the breakpoints_synced reconciliation path as well. But please don't read that as "not wanted" — two specific things to fix in your workflow so your other PRs can land:
The lockfile change is a security regression. Your pnpm-lock.yaml was regenerated by a different pnpm version and silently removed the entire overrides block — the pinned security floors for vite, qs, esbuild, hono, and five others — and downgraded esbuild from 0.28.2 to 0.27.7. Any PR carrying that diff can't be merged regardless of the code around it. When pnpm install rewrites the lockfile on your machine, git checkout pnpm-lock.yaml before committing.
pnpm-workspace.yaml picked up literal placeholder text (allowBuilds: esbuild: set this to true or false) — worth double-checking git diff before pushing so tool-generated scaffolding doesn't ride along.
Root cause on our side: the repo didn't pin packageManager, so different pnpm majors disagree about the lockfile. A pin is landing shortly, which should make this whole class of problem disappear.
I've left detailed reviews on #474 and #475 — both are fixable and wanted. Thanks for contributing, and hope to merge those soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #471. Clear or translate provisional breakpoint messages from js-debug (\�reakpoint.provisionalBreakpoint) when a breakpoint becomes verified.