Skip to content

Fix: Clear provisional js-debug breakpoint message when verified - #473

Closed
abhijeetnardele24-hash wants to merge 1 commit into
debugmcp:mainfrom
abhijeetnardele24-hash:fix/js-provisional-breakpoint-message
Closed

Fix: Clear provisional js-debug breakpoint message when verified#473
abhijeetnardele24-hash wants to merge 1 commit into
debugmcp:mainfrom
abhijeetnardele24-hash:fix/js-provisional-breakpoint-message

Conversation

@abhijeetnardele24-hash

Copy link
Copy Markdown
Contributor

Closes #471. Clear or translate provisional breakpoint messages from js-debug (\�reakpoint.provisionalBreakpoint) when a breakpoint becomes verified.

@debugmcpdev

Copy link
Copy Markdown
Collaborator

Thank you for this — you were first to pick up #471, and your instinct about the tricky part was genuinely right: the else-branch re-sanitizing the stored message when a verify update carries none is exactly the failure mode that a competing fix initially missed. Live verification confirmed js-debug's bind event omits message, and the merged fix (#476 + an amendment) handles it the same way you anticipated.

I'm closing this one in favor of #476, which arrived with unit tests and covered the breakpoints_synced reconciliation path as well. But please don't read that as "not wanted" — two specific things to fix in your workflow so your other PRs can land:

  1. The lockfile change is a security regression. Your pnpm-lock.yaml was regenerated by a different pnpm version and silently removed the entire overrides block — the pinned security floors for vite, qs, esbuild, hono, and five others — and downgraded esbuild from 0.28.2 to 0.27.7. Any PR carrying that diff can't be merged regardless of the code around it. When pnpm install rewrites the lockfile on your machine, git checkout pnpm-lock.yaml before committing.
  2. pnpm-workspace.yaml picked up literal placeholder text (allowBuilds: esbuild: set this to true or false) — worth double-checking git diff before pushing so tool-generated scaffolding doesn't ride along.

Root cause on our side: the repo didn't pin packageManager, so different pnpm majors disagree about the lockfile. A pin is landing shortly, which should make this whole class of problem disappear.

I've left detailed reviews on #474 and #475 — both are fixable and wanted. Thanks for contributing, and hope to merge those soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verified JS breakpoints keep the raw provisional message 'breakpoint.provisionalBreakpoint' (untranslated key + contradicts verified:true)

2 participants